Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and change logging for flipper initializer #18575

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

rmtolmach
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO

This PR makes the following changes:

  • Only send log message about considering removing features if there are any features to consider removing.
  • Log when a feature is added. This will hopefully help us figure out what is adding features and where outdated features.yml live.
  • Add an extra log in the rescue just to see if we've been hitting errors.

Related issue(s)

Testing done

There are no unit tests for this work. I will monitor dev and staging logs in datadog post-merge.

What areas of the site does it impact?

Flipper initializer

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link

Backend-review-group approval confirmed.

@rmtolmach rmtolmach merged commit 798d57a into master Sep 24, 2024
30 checks passed
@rmtolmach rmtolmach deleted the flipper_logging branch September 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants